Keira Knightley is latest star to publish a children’s book, but some say trend pushes aside genuine writers and makes it harder to find great children’s fiction